Draft
Conversation
Base automatically changed from
feature/allow-local-openshc-sources-files
to
main
March 2, 2026 21:14
gynt
force-pushed
the
feature/restructure-build-and-install
branch
from
cafb7b2 to
240ac00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the dll build in a dll build and a dll build and deploy target.
I first tried to use installs, but they do too much that I do not want.
This change has an impact on multiple PRs:
I also removed the configurable DLL output path, since the DLL now builds to a stable path.
While it still configures the all targets, it would now be possible to run the builds of the DLL and the EXE without the game.
The PR will stay draft until the other changes are figured out.